Accept serial zero on initial file-zone loads
perfloop-oss/coredns · Uncatalogued performance
https://perfloop.ai/t/oss/case_xcv7j43321
Verdict
VERIFIED · settled 2026-11-15 · merged as coredns/coredns#8774
What happened: The check fails before this change and passes with it.
Hypothesis
Initial file-zone configuration rejects an otherwise accepted master file when its SOA serial is zero. Setup supplies zero as a placeholder for an absent previous version, and the parser mistakes the first load for an unchanged reload. A native configuration check reproduces the rejection; the prevalence of zero-serial zone files is unknown. This is a correctness finding, not a measured performance claim.
fileParseWithParser calls its parser with serial 0 at setup.go:117. Parse returns serialErr when the matching first SOA equals a nonnegative serial argument. Its negative-serial mode accepts the same zero-serial master file. Initial configuration has no old generation whose serial could legitimately make this input unchanged.
The stored checker on prop_y5b5kaevcf first accepted configured files at serials 1 and 4294967295, then rejected serial zero. The saved JSON now replays only zero. checkProperty call_sAwE159OEcVVYeDfUsKiQOra ran go test ./plugin/file -run '^TestPerfloopInitialSerialBounded$' -count=1 -timeout=60s -v and failed with the unchanged-serial error. The test also successfully parses the same three-record input through the explicit initial-load mode before exercising the real fileParse configuration seam. Exit status 1 is the reproduced assertion failure, not a compiler or fixture failure.
Related hypothesis hyp_r4th607trh concerns the mtime caller in reload.go. This finding concerns the independent initial-load call in setup.go. Changing only the mtime caller does not make a zero-serial file load at startup. The mtime witness was separately strengthened to start from serial 1 and rewrite to zero, and still failed in checkProperty call_ed9WOrPAauk2rrEYR1j3QuWu.
The inspected setup.go patch in https://github.com/coredns/coredns/pull/8067 adds build constraints and moves registration; it does not change this parser argument. https://github.com/coredns/coredns/pull/8700 changes SOA owner comparison, not initial serial selection. Recent merged-history and discussion-archive coverage remain incomplete: local history is shallow, the attempted history API read was refused, and the advertised Google Groups venue refused a bounded read.
The Case should establish initial acceptance across supported serial values, including zero, while preserving ordinary reload equality rejection, invalid-file rejection and actual stored RRsets. The cheapest next check is the saved configuration replay and the nonzero controls. Native regression coverage is required by the contribution guide; the present checker layout is provisional.
Change to test: Mark initial configured file loads as having no previous SOA serial instead of supplying a real serial value to the reload comparison. Preserve valid unchanged-serial rejection for ordinary reloads.
Where it lives
perfloop-oss/coredns · plugin/file/file.go
Evidence
The check fails before this change and passes with it: `On initial configuration with no prior zone, the file backend loads valid zones with SOA serials 0, 1 and 4294967295 in either reload mode and serves their SOA, NS and A records.`
The check fails before this change and passes with it: `For a file backend starting at serial 1, mtime reloads publish valid serial-0 changes, including repeated serial-0 changes; invalid files retain the prior records, serial-based reloads reject unchanged serials, and both modes load serial 4294967295.`
The check fails before this change and passes with it: `For valid master files with SOA serials 0, 1 and 4294967295, auto directory scanning loads newly discovered zones and serves their SOA, NS and A records.`
Checks: 3 of 3 passed. Verification: no defect found.